Feature/28 local base urls #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextreme
reviewed
Apr 4, 2024
alextreme
reviewed
Apr 4, 2024
| @@ -7,6 +9,21 @@ | |||
| from rest_framework.request import Request | |||
|
|
|||
|
|
|||
| def is_local(host: str, url: str) -> bool: | |||
There was a problem hiding this comment.
Could we have a few unittests for only this method? I'm all in favor of integration tests but this feels complicated enough to test separately as well
alextreme
approved these changes
Apr 4, 2024
stevenbal
reviewed
Apr 5, 2024
stevenbal
approved these changes
Apr 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 99.78% 99.80% +0.01%
==========================================
Files 14 15 +1
Lines 476 516 +40
==========================================
+ Hits 475 515 +40
Misses 1 1 ☔ View full report in Codecov by Sentry. |
annashamray
force-pushed
the
feature/28-local-base-urls
branch
from
828fff0 to
11e73b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28