🐛 [#32] Remove port number before using validate_host

django_loose_fk/loaders.py

@@ -11,7 +11,7 @@
 from django.utils.functional import LazyObject, empty
 from django.utils.module_loading import import_string
 
-from .utils import get_resource_for_path
+from .utils import get_resource_for_path, strip_port_number_and_lowercase
 from .virtual_models import get_model_instance
 
 SETTING = "DEFAULT_LOOSE_FK_LOADER"
@@ -55,12 +55,16 @@ def is_local_url(self, url: str) -> bool:
                 "break django-loose-fk's behaviour. You should use an explicit list.",
                 RuntimeWarning,
             )
-            return validate_host(parsed.netloc, allowed_hosts)
+            return validate_host(
+                strip_port_number_and_lowercase(parsed.netloc), allowed_hosts
+            )
 
         if local_base_urls:
             return any(url.startswith(base_url) for base_url in local_base_urls)
 
-        return validate_host(parsed.netloc, allowed_hosts)
+        return validate_host(
+            strip_port_number_and_lowercase(parsed.netloc), allowed_hosts
+        )
 
     def load_local_object(self, url: str, model: ModelBase) -> models.Model:
         parsed = urlparse(url)

django_loose_fk/utils.py

@@ -70,3 +70,7 @@ def get_subclasses(cls):
     for subclass in cls.__subclasses__():
         yield from get_subclasses(subclass)
         yield subclass
+
+
+def strip_port_number_and_lowercase(netloc: str) -> str:
+    return netloc.split(":")[0].lower()

testapp/settings.py

@@ -52,6 +52,6 @@ def get_db():
 
 ROOT_URLCONF = "testapp.urls"
 
-ALLOWED_HOSTS = ["testserver.com"]
+ALLOWED_HOSTS = ["testserver.com", "testserver.local"]
 
 USE_TZ = False

tests/test_loaders.py

@@ -29,3 +29,10 @@ def test_failed_not_json():
 
         with pytest.raises(FetchJsonError):
             default_loader.load("https://example.com", ZaakType)
+
+
+def test_is_local_url():
+    assert default_loader.is_local_url("https://testserver.com/some-resource")
+    assert default_loader.is_local_url("https://testserver.local:443/some-resource")
+    assert default_loader.is_local_url("https://TESTSERVER.LOCAL:443/some-resource")
+    assert not default_loader.is_local_url("https://example.com/some-resource")