-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 #600 - changed the error on 403 without session #612
base: main
Are you sure you want to change the base?
Conversation
646195d
to
d1f5aa6
Compare
6240499
to
1732718
Compare
@svenvandescheur if needed, we can add Silvia as a reviewer aswell |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 205 205
Lines 5968 5991 +23
Branches 619 621 +2
=======================================
+ Hits 5181 5201 +20
- Misses 787 790 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small remarks, looks good otherwise.
|
||
|
||
@tag("e2e") | ||
@override_settings(SESSION_COOKIE_AGE=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this 0/1 no?
|
||
const flatten = Object.values(errors || {}) | ||
.flat() | ||
.filter((error) => error !== "session_expired"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only works for the "session_expired" code, I think we should just filter out any record with the key "code", also please add some documentation on why this is and update the test file with a testcase for it :)
closes #600
code
on the session expiry edge casesession_expired
code is provided as a response error