Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [#3059] Refactoring of searchpage Sidebar/grids #1638

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Feb 25, 2025

Rearranged grid, in order to make space for filters on desktop
https://taiga.maykinmedia.nl/project/open-inwoner/task/3059

@jiromaykin jiromaykin changed the title 🚧 [#3059] Reconstruction of all searchpage grids 🚧 [#3059] Refactoring of searchpage grids Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (d6195b2) to head (8b83a97).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1638      +/-   ##
===========================================
- Coverage    94.17%   94.16%   -0.01%     
===========================================
  Files         1086     1086              
  Lines        40071    40109      +38     
===========================================
+ Hits         37735    37767      +32     
- Misses        2336     2342       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jiromaykin jiromaykin marked this pull request as ready for review February 25, 2025 12:16
@jiromaykin
Copy link
Contributor Author

@stefrado I tried a CSS only solution first, but that won't work, since it's grids-inside-grids-inside grids...
+the Grids need to respond to having filters set on/off by municipalities, so this refactoring into columns might be the better solution. Other pages won't have this problem with multiple grids, but feel free to suggest better!

@jiromaykin jiromaykin requested a review from stefrado February 25, 2025 12:20
@jiromaykin jiromaykin changed the title 🚧 [#3059] Refactoring of searchpage grids 🚧 [#3059] Refactoring of searchpage Sidebar/grids Feb 25, 2025
@jiromaykin jiromaykin changed the title 🚧 [#3059] Refactoring of searchpage Sidebar/grids ♻️ [#3059] Refactoring of searchpage Sidebar/grids Feb 27, 2025
@jiromaykin jiromaykin force-pushed the feature/3059-TEST-wider-search-sidebar branch from c6b057c to 71eaba3 Compare March 4, 2025 12:44
@stefrado
Copy link
Contributor

stefrado commented Mar 4, 2025

Feedback

Some incorrect styled elements (see screenshot)

  1. The pagination alignment is not correct.
  2. The feedback form is not aligned correct.

image

Code formatting

  1. The html of search.html isn't formatted properly
    • Some inconsistent blank lines.
    • Added left whitespace on some places where it shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants