✨ #993 ADD celery task 1: every day check that extracts ever… #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m each localized product and checks if the URL is valid - task 2: every month send monthly report bout the links
joeribekker
approved these changes
Dec 10, 2024
Comment on lines
49
to
52
| product_dict = defaultdict(lambda: defaultdict(list)) | ||
| url_set = set() | ||
| url_response_status_codes = defaultdict(int) | ||
| founded_broken_link_ids = [] |
There was a problem hiding this comment.
Please don't use class-level attributes (that are initialized).
If you find this is needed because multiple functions are writing or reading the same class-variable, then the functions are incorrect or you need to pass the data around as argument to the next function.
For example, your function get_products_to_check doesn't "get" products. It fills a variable with products. Just, make this function return the products instead of filling a class-level variable.
There was a problem hiding this comment.
I tried to fix this in adc0602 ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993