Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cors header on get response #46

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

felipelube
Copy link
Contributor

@felipelube felipelube commented Nov 6, 2024

  • Allow simple requests (those made without a preflight request) to access the files from a cross-origin when the cors configuration is enabled.
  • Improve CORS test coverage for POST and PUT methods.

Rationale: while using this project to serve local files in a development environment, I found the need to have this to simplify the developer experience.

@mayth mayth merged commit ac9dbf3 into mayth:v2 Nov 10, 2024
3 of 4 checks passed
@mayth
Copy link
Owner

mayth commented Nov 16, 2024

@felipelube sorry for late reply.
Now your changes are available in latest image.
Thank you for your contribution!

P.S. The "publish" check in this PR was failed but it is normal behavior (but unexpected). I'll disable it in PR build...

@felipelube felipelube deleted the feat/add-cors-header-on-get-response branch November 19, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants