fix: support sharkd path with spaces #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process.spawn supports command and arg handling for the command parameter. But it doesn't expect the path to be part of the command but to use the cwd option for that. Use path.parse to split the sharkdPath into dir and base and pass these as args. Added support for sharkdPath without dir as well defaulting to process.cwd(). Seems like the logic is not needed for tshark as there a seperator... is used. Issue: about settings #29
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.spawn supports command and arg handling for the command parameter. But it doesn't expect the path to be part of the command but to use the cwd option for that. Use path.parse to split the sharkdPath into dir and base and pass these as args. Added support for sharkdPath without dir as well defaulting to process.cwd().
Seems like the logic is not needed for tshark as there a seperator... is used.
Issue: about settings #29