Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if not in debug mode return immediately from PrintTree #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vbargsten
Copy link

Changes from #7 (comment)

@mbideau
Copy link
Owner

mbideau commented Mar 8, 2023

Perfect.
Can I ask you to also remove the if condition (https://github.com/mbideau/btrfs-diff-go/blob/master/pkg/btrfs-diff.go#L173) which is now useless, please.
Also can you add yourself to the Contributors section (https://github.com/mbideau/btrfs-diff-go/blob/master/README.md?plain=1#L315) with the naming and description you want ... I suggest « vbargsten: an awesome help in testing on real data, and performance fixes 🧪 » 😉
Then I'll happily merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants