Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dstr #366

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Fix dstr #366

merged 1 commit into from
Mar 16, 2025

Conversation

mbj
Copy link
Owner

@mbj mbj commented May 28, 2024

No description provided.

@mbj mbj mentioned this pull request Jun 22, 2024
@mbj mbj force-pushed the fix/dstr branch 2 times, most recently from d6931fd to 7ac3ca1 Compare September 16, 2024 03:17
@mbj mbj force-pushed the fix/dstr branch 4 times, most recently from bf874eb to 4e16935 Compare September 20, 2024 21:26
@mbj mbj force-pushed the fix/dstr branch 2 times, most recently from e974b10 to 875dda1 Compare February 14, 2025 03:26
@@ -78,4 +83,4 @@ DEPENDENCIES
unparser!

BUNDLED WITH
2.5.10
2.5.22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: (nitpick) FYI the current version of bundler is 2.6.3

@mbj mbj closed this Mar 16, 2025
@mbj mbj reopened this Mar 16, 2025
@mbj mbj force-pushed the fix/dstr branch 2 times, most recently from 5751efd to ea570b2 Compare March 16, 2025 05:16
* This is an entirely new approach.
* Instead to find the "correct" dstr segments we simply try all and unparse the first one
  that round trips.
* This so far guarantees we always get good concrete syntax, but it can be time intensive as
  the combinatoric space of possible dynamic string sequence is quadratic with the dstr children size.
* For this reason we try above (currently) dstr children to unparse as heredoc first.
* Passes the entire corpus and fixes bugs.

[fix #249]
@mbj mbj merged commit 935ba71 into main Mar 16, 2025
32 checks passed
@mbj mbj deleted the fix/dstr branch March 16, 2025 05:25
@mbj mbj mentioned this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants