Fix dstr #366
Merged
Fix dstr #366
+1,597
−908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mbj
force-pushed
the
fix/dstr
branch
2 times, most recently
from
d6931fd to
7ac3ca1
Compare
dkubb
reviewed
Sep 16, 2024
mbj
force-pushed
the
fix/dstr
branch
4 times, most recently
from
bf874eb to
4e16935
Compare
mbj
force-pushed
the
fix/dstr
branch
2 times, most recently
from
e974b10 to
875dda1
Compare
dkubb
reviewed
Feb 14, 2025
| @@ -78,4 +83,4 @@ DEPENDENCIES | |||
| unparser! | |||
|
|
|||
| BUNDLED WITH | |||
| 2.5.10 | |||
| 2.5.22 | |||
There was a problem hiding this comment.
suggestion: (nitpick) FYI the current version of bundler is 2.6.3
mbj
force-pushed
the
fix/dstr
branch
2 times, most recently
from
5751efd to
ea570b2
Compare
* This is an entirely new approach. * Instead to find the "correct" dstr segments we simply try all and unparse the first one that round trips. * This so far guarantees we always get good concrete syntax, but it can be time intensive as the combinatoric space of possible dynamic string sequence is quadratic with the dstr children size. * For this reason we try above (currently) dstr children to unparse as heredoc first. * Passes the entire corpus and fixes bugs. [fix #249]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.