Issue 10 - prepare test environment and start refactoring #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mborne
commented
Aug 15, 2018
mborne
commented
- Add tests based on phpunit
- Start refactoring
- Remove dependency to gitlab-client (direct calls to API with guzzle http)
…; remove depenency to gitlab api client (use guzzlehttp)
|
work is not complete for issue #10 but merging will allow contribution on a better base |
|
Did a quick review, look good to me. Thanks a bunch. |
|
Thanks for your review and the new option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.