feat: added more tests

src/lib/binding/types.ts

@@ -1,9 +1,13 @@
 import { type Observable } from "rxjs"
 
-export type SubscribeSource<Data> =
+export type SubscribeSourceFactory<Data> =
   | (() => Observable<Data>)
-  | Promise<Data>
-  | Observable<Data>
+  | (() => Observable<Data> | undefined)
   | (() => Promise<Data>)
   | (() => Data)
+
+export type SubscribeSource<Data> =
+  | SubscribeSourceFactory<Data>
+  | Promise<Data>
+  | Observable<Data>
   | Data

src/lib/binding/useObserve.ts

@@ -53,7 +53,7 @@ export function useObserve<T>(
     !maybeDeps && Array.isArray(optionsOrDeps)
       ? optionsOrDeps
       : typeof source$ === "function"
-        ? maybeDeps ?? []
+        ? (maybeDeps ?? [])
         : [source$]
   const valueRef = useRef(
     "getValue" in source$ && typeof source$.getValue === "function"

src/lib/binding/useSubscribe.test.tsx

@@ -0,0 +1,54 @@
+import { afterEach, describe, expect, it } from "vitest"
+import { type Observable, of, tap } from "rxjs"
+import { renderHook, cleanup } from "@testing-library/react"
+import { useEffect, useState } from "react"
+import { waitForTimeout } from "../../tests/utils"
+import { useSubscribe } from "./useSubscribe"
+
+afterEach(() => {
+  cleanup()
+})
+
+describe("Given a function that returns undefined", () => {
+  it("should subscribe and does nothing", async () => {
+    const maybeObservableFn = () => undefined as Observable<number> | undefined
+
+    renderHook(() => {
+      useSubscribe(maybeObservableFn, [])
+    }, {})
+
+    expect(true).toBe(true)
+  })
+
+  describe("when the function returns an observable later", () => {
+    it("should update and subscribe", async () => {
+      let testValue = 0
+
+      renderHook(() => {
+        const [value, setValue] = useState<Observable<number> | undefined>(
+          undefined
+        )
+
+        useSubscribe(
+          () =>
+            value?.pipe(
+              tap((v) => {
+                testValue = v
+              })
+            ),
+          [value]
+        )
+
+        useEffect(() => {
+          setTimeout(() => {
+            setValue(of(5))
+          }, 10)
+        }, [])
+      }, {})
+
+      await waitForTimeout(15)
+
+      expect(testValue).toBe(5)
+    })
+  })
+})

src/lib/binding/useSubscribe.ts

@@ -5,7 +5,7 @@ import { type SubscribeSource } from "./types"
 import { catchError, EMPTY } from "rxjs"
 
 export function useSubscribe<T>(
-  source: SubscribeSource<T>,
+  source: SubscribeSource<T> | (() => T),
   deps: DependencyList = []
 ) {
   const sourceRef = useLiveRef(source)
@@ -29,4 +29,4 @@ export function useSubscribe<T>(
     ...deps,
     sourceRef
   ])
-}
+}

src/lib/queries/client/queries/query/getDefaultState.ts

@@ -26,7 +26,7 @@ export function getDefaultState<
   return {
     data,
     dataUpdateCount: 0,
-    dataUpdatedAt: hasData ? initialDataUpdatedAt ?? Date.now() : 0,
+    dataUpdatedAt: hasData ? (initialDataUpdatedAt ?? Date.now()) : 0,
     error: null,
     errorUpdateCount: 0,
     errorUpdatedAt: 0,

src/lib/queries/client/queries/query/operators.ts

@@ -26,7 +26,9 @@ export const reduceState =
 
         if (command === "cancel") {
           const status =
-            acc.status === "pending" ? "pending" : current.status ?? acc.status
+            acc.status === "pending"
+              ? "pending"
+              : (current.status ?? acc.status)
 
           return { ...acc, ...current, status }
         }
@@ -61,15 +63,15 @@ export const reduceState =
 
         const dataUpdateCount = weHaveNewData
           ? acc.dataUpdateCount + 1
-          : current.dataUpdateCount ?? acc.dataUpdateCount
+          : (current.dataUpdateCount ?? acc.dataUpdateCount)
 
         const newPendingStatusOnHold =
           current.status === "pending" &&
           previousStatusIsSuccessOrError &&
           // (dataUpdateCount !== 0 || errorUpdateCount !== 0)
           (hasData || hasError)
 
-        const error = status === "pending" ? null : current.error ?? acc.error
+        const error = status === "pending" ? null : (current.error ?? acc.error)
 
         return {
           ...acc,

src/lib/utils/operators/retryBackoff.ts

@@ -64,7 +64,7 @@ export function retryBackoff<T, TError>(config: RetryBackoffConfig<T, TError>) {
         ? 0
         : retry === true
           ? Infinity
-          : retry ?? Infinity
+          : (retry ?? Infinity)
       : Infinity
 
   const shouldRetry =

vite.config.ts

@@ -27,5 +27,5 @@ export default defineConfig({
     },
     // handled by consumer
     minify: true
-  },
+  }
 })