Current legacy regex #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to the latest uap-core (git submodule) to pull in the latest regexp file addresses github issue ua-parser#38 updates UserAgentParser to pass all regexp unit tests update README to explain how to work with the uap-core git submodule
looping over a synchronized list needs to be done inside of a synchronized block which is not what we want
ISSUE-22 bump uap-core 0.9.10
Use dependencies for yaml files from uap-core
This reverts commit 70ab5de.
This reverts commit 5c37a75
Fix test ParserTest
Update org.yaml:snakeyaml from 1.20 to 1.26 to resolve security vulnerability
fix unnecessary duplicate initialization
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <[email protected]>
…-junit-4.13.1 security: bump junit from 4.12 to 4.13.1
The versioning schemes for uap-core and its derivative ua_parser are independent of each other. This change fast-forwards the uap-core version to the release used in the newest uap-python release 0.10.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized I opened the pull request in the original repo, so Tabea's comments are there (the changes she requested are moved to here though).
Since we can't import two different versions of the same library, I copy-pasted some code to make a distinction between the popper (current) and dmp (legacy) branch.
uap_javais a language-specific wrapper arounduap-core, which in turn is just a list of regexes and test cases for them. Knowing that, I just made two separate parser classes, one for each version ofuap-core. DMP should be able to import both of them and use them individually for each model.