Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block access to admin pages when 2fa is disabled #667

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

nlwstein
Copy link
Contributor

@nlwstein nlwstein commented Aug 28, 2023

Summary of changes

Asana Ticket: 🍎 Force 2FA for API admins

This PR also addresses 🍎 API "Login" and "Register" links should not appear if user is already logged in

Adds a Plug that can restrict access to URLs until the user enables 2 factor authentication, and applies it to /admin routes.

Updates footer behavior so that USER_EMAIL / Log Out is shown instead of Login / Register when the user is already in a logged-in session.

@nlwstein nlwstein requested a review from bfauble August 29, 2023 14:07
@nlwstein nlwstein marked this pull request as ready for review August 29, 2023 14:07
@nlwstein nlwstein requested review from a team and removed request for bfauble August 29, 2023 14:08
Copy link
Collaborator

@Whoops Whoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nlwstein nlwstein merged commit ed3dc89 into master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants