feat: accept MQTT connections for Vehicle Positions #673

paulswartz · 2023-09-17T13:31:36Z

Summary of changes

Creates a new MqttMediator which accepts messages from an MQTT topic and sends them to the appropriate State module. We hook this up to the Vehicle state to more efficiently accept vehicle location updates.

Asana Ticket: V3 API: Consume MQTT updates

github-actions · 2023-09-20T13:43:51Z

Coverage of commit `708210f`

Summary coverage rate:
  lines......: 89.5% (4083 of 4564 lines)
  functions..: 70.9% (2232 of 3149 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/server.ex                                        |92.0%    113|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |77.3%     22|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

github-actions · 2023-09-20T18:29:23Z

Coverage of commit `ca81edc`

Summary coverage rate:
  lines......: 89.5% (4089 of 4569 lines)
  functions..: 70.9% (2231 of 3148 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/route.ex                                         |75.9%     29|68.0%    50|    -      0
  apps/state/lib/state/route_pattern.ex                                 | 100%     23|64.3%    42|    -      0
  apps/state/lib/state/server.ex                                        |93.2%    117|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |77.3%     22|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

paulswartz · 2023-09-20T18:42:28Z

Moving back to draft while I investigate an issue with excess memory usage.

github-actions · 2023-09-20T20:23:07Z

Coverage of commit `c80435b`

Summary coverage rate:
  lines......: 89.5% (4087 of 4569 lines)
  functions..: 70.8% (2221 of 3135 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/route.ex                                         |75.9%     29|67.3%    49|    -      0
  apps/state/lib/state/route_pattern.ex                                 | 100%     23|63.4%    41|    -      0
  apps/state/lib/state/server.ex                                        |93.2%    117|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |77.3%     22|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

github-actions · 2023-09-25T18:59:11Z

Coverage of commit `ac7347d`

Summary coverage rate:
  lines......: 89.5% (4093 of 4573 lines)
  functions..: 70.8% (2221 of 3135 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/route.ex                                         |75.9%     29|67.3%    49|    -      0
  apps/state/lib/state/route_pattern.ex                                 | 100%     23|63.4%    41|    -      0
  apps/state/lib/state/server.ex                                        |93.3%    120|96.7%    30|    -      0
  apps/state/lib/state/vehicle.ex                                       |91.9%     37|72.9%    48|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |77.3%     22|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

github-actions · 2023-09-27T13:53:01Z

Coverage of commit `aa70cdd`

Summary coverage rate:
  lines......: 89.4% (4092 of 4576 lines)
  functions..: 70.8% (2221 of 3135 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/route.ex                                         |75.9%     29|67.3%    49|    -      0
  apps/state/lib/state/route_pattern.ex                                 | 100%     23|63.4%    41|    -      0
  apps/state/lib/state/server.ex                                        |91.1%    124|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |77.3%     22|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

github-actions · 2023-09-27T16:35:35Z

Coverage of commit `c993525`

Summary coverage rate:
  lines......: 89.4% (4093 of 4576 lines)
  functions..: 70.9% (2222 of 3136 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/server.ex                                        |91.1%    124|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |77.3%     22|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

This allows us to add new environment variables for the MQTT broker, without breaking existing API instances which expect the source to be an HTTPS URL.

github-actions · 2023-09-27T16:51:12Z

Coverage of commit `6fd7c1a`

Summary coverage rate:
  lines......: 89.4% (4094 of 4577 lines)
  functions..: 70.9% (2222 of 3136 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/server.ex                                        |91.1%    124|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |78.3%     23|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

github-actions · 2023-10-03T13:37:00Z

Coverage of commit `20c2c7d`

Summary coverage rate:
  lines......: 89.4% (4092 of 4577 lines)
  functions..: 70.9% (2222 of 3136 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/parse/lib/parse/vehicle_positions.ex                             |50.0%     46| 100%     7|    -      0
  apps/parse/lib/parse/vehicle_positions_json.ex                        |67.9%     28| 100%     7|    -      0
  apps/state/lib/state/server.ex                                        |91.1%    124|96.7%    30|    -      0
  apps/state_mediator/lib/state_mediator.ex                             |15.0%     20|16.7%     6|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator.ex               |78.3%     23|62.5%     8|    -      0
  apps/state_mediator/lib/state_mediator/mqtt_mediator/handler.ex       |77.8%      9|85.7%     7|    -      0

Download coverage report

paulswartz force-pushed the ps-mqtt branch 7 times, most recently from 9bd8d86 to 4184923 Compare September 20, 2023 13:30

mbta deleted a comment from github-actions bot Sep 20, 2023

paulswartz requested review from a team and bfauble September 20, 2023 13:33

paulswartz marked this pull request as ready for review September 20, 2023 13:34

paulswartz force-pushed the ps-mqtt branch from 4184923 to 708210f Compare September 20, 2023 13:35

paulswartz temporarily deployed to dev-green September 20, 2023 14:36 — with GitHub Actions Inactive

paulswartz had a problem deploying to dev-green September 20, 2023 18:14 — with GitHub Actions Error

paulswartz marked this pull request as draft September 20, 2023 18:42

paulswartz force-pushed the ps-mqtt branch from ca81edc to c80435b Compare September 20, 2023 20:08

paulswartz temporarily deployed to dev-green September 20, 2023 20:08 — with GitHub Actions Inactive

paulswartz force-pushed the ps-mqtt branch from c80435b to ac7347d Compare September 25, 2023 18:44

paulswartz had a problem deploying to dev-green September 25, 2023 18:45 — with GitHub Actions Error

paulswartz force-pushed the ps-mqtt branch from ac7347d to 2caffc1 Compare September 27, 2023 13:17

paulswartz had a problem deploying to dev-green September 27, 2023 13:17 — with GitHub Actions Error

paulswartz force-pushed the ps-mqtt branch from 2caffc1 to aa70cdd Compare September 27, 2023 13:44

paulswartz temporarily deployed to dev-green September 27, 2023 13:45 — with GitHub Actions Inactive

paulswartz force-pushed the ps-mqtt branch from aa70cdd to c993525 Compare September 27, 2023 16:25

feat(parse): accept gzip-encoded values for VehiclePositions

a581473

paulswartz force-pushed the ps-mqtt branch from c993525 to f104b09 Compare September 27, 2023 16:33

paulswartz marked this pull request as ready for review September 27, 2023 16:33

paulswartz added 3 commits September 27, 2023 12:39

feat: MqttMediator option for Vehicle Positions

2d4b74c

feat: make MqttMediator config separate from the SOURCE envvar

29f78d8

This allows us to add new environment variables for the MQTT broker, without breaking existing API instances which expect the source to be an HTTPS URL.

feat(Server): accept partial updates

6fd7c1a

paulswartz force-pushed the ps-mqtt branch from f104b09 to 6fd7c1a Compare September 27, 2023 16:39

bfauble approved these changes Oct 3, 2023

View reviewed changes

paulswartz temporarily deployed to dev-green October 3, 2023 13:18 — with GitHub Actions Inactive

Merge branch 'master' into ps-mqtt

20c2c7d

paulswartz merged commit 5dcbdef into master Oct 3, 2023
7 checks passed

paulswartz deleted the ps-mqtt branch October 3, 2023 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: accept MQTT connections for Vehicle Positions #673

feat: accept MQTT connections for Vehicle Positions #673

paulswartz commented Sep 17, 2023 •

edited

Loading

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

paulswartz commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 25, 2023

github-actions bot commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

github-actions bot commented Oct 3, 2023

feat: accept MQTT connections for Vehicle Positions #673

feat: accept MQTT connections for Vehicle Positions #673

Conversation

paulswartz commented Sep 17, 2023 • edited Loading

Summary of changes

github-actions bot commented Sep 20, 2023

Coverage of commit 708210f

github-actions bot commented Sep 20, 2023

Coverage of commit ca81edc

paulswartz commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

Coverage of commit c80435b

github-actions bot commented Sep 25, 2023

Coverage of commit ac7347d

github-actions bot commented Sep 27, 2023

Coverage of commit aa70cdd

github-actions bot commented Sep 27, 2023

Coverage of commit c993525

github-actions bot commented Sep 27, 2023

Coverage of commit 6fd7c1a

github-actions bot commented Oct 3, 2023

Coverage of commit 20c2c7d

paulswartz commented Sep 17, 2023 •

edited

Loading

Coverage of commit `708210f`

Coverage of commit `ca81edc`

Coverage of commit `c80435b`

Coverage of commit `ac7347d`

Coverage of commit `aa70cdd`

Coverage of commit `c993525`

Coverage of commit `6fd7c1a`

Coverage of commit `20c2c7d`