Pass through internal modifier for Konverter interfaces

mcarleio · Jul 2, 2024 · 5d13e5d · 5d13e5d
1 parent 6a4391c
commit 5d13e5d
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 0 deletions.
diff --git a/docs/annotations/konverter.adoc b/docs/annotations/konverter.adoc
@@ -12,6 +12,8 @@ You can define custom mappings and options per function using the xref:konvert.a
 
 If a member function is a `suspend fun`, the generated counterpart is also a `suspend fun`.
 
+If a `@Konverter`-annotated interface is `internal`, the generated object or class is also `internal`.
+
 [source,kotlin]
 ----
 @Konverter

diff --git a/processor/src/main/kotlin/io/mcarle/konvert/processor/konvert/KonverterCodeGenerator.kt b/processor/src/main/kotlin/io/mcarle/konvert/processor/konvert/KonverterCodeGenerator.kt
@@ -142,6 +142,9 @@ object KonverterCodeGenerator {
                     injectors.forEach {
                         it.processType(typeBuilder, konverterInterface.kSClassDeclaration)
                     }
+                    if (konverterInterface.isInternal) {
+                        typeBuilder.addModifiers(KModifier.INTERNAL)
+                    }
                 }
 
         }

diff --git a/processor/src/main/kotlin/io/mcarle/konvert/processor/konvert/KonverterInterface.kt b/processor/src/main/kotlin/io/mcarle/konvert/processor/konvert/KonverterInterface.kt
@@ -1,5 +1,6 @@
 package io.mcarle.konvert.processor.konvert
 
+import com.google.devtools.ksp.isInternal
 import com.google.devtools.ksp.symbol.KSClassDeclaration
 import com.squareup.kotlinpoet.ksp.toTypeName
 
@@ -9,4 +10,5 @@ data class KonverterInterface constructor(
     val simpleName = kSClassDeclaration.simpleName.asString()
     val packageName = kSClassDeclaration.packageName.asString()
     val typeName = kSClassDeclaration.asStarProjectedType().toTypeName()
+    val isInternal = kSClassDeclaration.isInternal()
 }
diff --git a/processor/src/test/kotlin/io/mcarle/konvert/processor/konvert/KonvertITest.kt b/processor/src/test/kotlin/io/mcarle/konvert/processor/konvert/KonvertITest.kt
@@ -1720,6 +1720,32 @@ interface Mapper {
         assertContains(mapperCode, "suspend fun toTarget(source: SourceClass): TargetClass")
         assertContains(mapperCode, "suspend fun toTarget(source: SourceProperty): TargetProperty")
     }
+
+    @Test
+    fun internalInterface() {
+        val (compilation) = compileWith(
+            enabledConverters = listOf(SameTypeConverter()),
+            code = SourceFile.kotlin(
+                name = "TestCode.kt",
+                contents =
+                """
+import io.mcarle.konvert.api.Konverter
+
+class SourceClass(val property: String)
+class TargetClass(val property: String)
+
+@Konverter
+internal interface Mapper {
+    fun toTarget(source: SourceClass): TargetClass
+}
+                """.trimIndent()
+            )
+        )
+        val mapperCode = compilation.generatedSourceFor("MapperKonverter.kt")
+        println(mapperCode)
+
+        assertContains(mapperCode, "internal object MapperImpl : Mapper {")
+    }
 }
 
 private fun Konverter.Companion.getWithClassLoader(classFQN: String, classLoader: ClassLoader): Any {