Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code and fix for new versions #35

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

alisonjenkins
Copy link

  • Updates the cargo dependencies and adjusts the code to work with the new version of clap.
  • Sets the Rust edition and adjusts the code as appropriately.
  • Fixes all clippy lints that were found on the code.
  • Tests all pass.

@mcasper
Copy link
Owner

mcasper commented Oct 29, 2024

Hey @alisonjenkins, thanks so much for doing all this work to modernize the project! The Rust parts look great!

Could you drop the Nix specific files from the changes, or add them to the gitignore? After that I think this should be good to merge

@alisonjenkins
Copy link
Author

Hey @alisonjenkins, thanks so much for doing all this work to modernize the project! The Rust parts look great!

Could you drop the Nix specific files from the changes, or add them to the gitignore? After that I think this should be good to merge

Are you sure you want to get rid of them? They are basically packaging the project for Nix and providing a devshell that enables anyone using Nix to basically just run nix develop and be setup to be able to build and develop the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants