Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasdaemon: Modify support for vendor-specific machine check error inf… #181

Closed
wants to merge 1 commit into from
Closed

rasdaemon: Modify support for vendor-specific machine check error inf… #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions mce-amd-smca.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,16 +993,8 @@ void decode_smca_error(struct mce_event *e, struct mce_priv *m)
channel, csrow);
}

if (e->vdata_len) {
uint64_t smca_config = e->vdata[2];

/*
* BIT 9 of the CONFIG register of a few SMCA Bank types indicates
* presence of FRU Text in SYND 1 / 2 registers
*/
if (smca_config & BIT(9))
memcpy(e->frutext, e->vdata, 16);
}
if (e->vdata_len)
memcpy(e->frutext, e->vdata, 16);
}

int parse_amd_smca_event(struct ras_events *ras, struct mce_event *e)
Expand Down
14 changes: 1 addition & 13 deletions ras-mce-handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,20 +376,8 @@ static void report_mce_event(struct ras_events *ras,
if (!e->vdata_len)
return;

if (strlen(e->frutext)) {
if (strlen(e->frutext))
trace_seq_printf(s, ", FRU Text= %s", e->frutext);
trace_seq_printf(s, ", Vendor Data= ");
for (int i = 2; i < e->vdata_len / 8; i++) {
trace_seq_printf(s, "0x%lx", e->vdata[i]);
trace_seq_printf(s, " ");
}
} else {
trace_seq_printf(s, ", Vendor Data= ");
for (int i = 0; i < e->vdata_len / 8; i++) {
trace_seq_printf(s, "0x%lx", e->vdata[i]);
trace_seq_printf(s, " ");
}
}

/*
* FIXME: The original mcelog userspace tool uses DMI to map from
Expand Down
Loading