Skip to content

Commit

Permalink
updated ObjectTable deleteItem -> delete for consistent api in js
Browse files Browse the repository at this point in the history
  • Loading branch information
fraguada committed Nov 20, 2024
1 parent a3312f8 commit 1c69e3c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/bindings/bnd_extensions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2080,7 +2080,7 @@ void initExtensionsBindings(void*)
.function("addObject", &BND_ONXModel_ObjectTable::AddObject, allow_raw_pointers())
.function("addInstanceObject", &BND_ONXModel_ObjectTable::AddInstanceObject2, allow_raw_pointers())
.function("getBoundingBox", &BND_ONXModel_ObjectTable::GetBoundingBox)
.function("deleteItem", &BND_ONXModel_ObjectTable::Delete)
.function("delete", &BND_ONXModel_ObjectTable::Delete)
.function("findId", &BND_ONXModel_ObjectTable::FindId, allow_raw_pointers())
;

Expand Down
2 changes: 1 addition & 1 deletion tests/javascript/file3dm.ObjectTable.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ test('DeleteObject', async () => {

const qtyObjects1 = file3dm.objects().count

file3dm.objects().deleteItem(id1)
file3dm.objects().delete(id1)

const qtyObjects2 = file3dm.objects().count

Expand Down

0 comments on commit 1c69e3c

Please sign in to comment.