[Python] Update stubs after #665 and #666 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #665, this PR updates the stubs for
AddPointandAddLineafter the modifications on the binding code in #665 and #666.In my humble opinion, overload stubs were not correctly set and, at least in Windows 10 - VSCode - Python 3.13, only the first definition of
AddPointwas shown via IntelliSense. With the proposed changes, everything seems to be ok (I did not trymacosorLinux).There might be other overload stubs that suffer the same issue, e.g.,
class Arc.__init__(...)orclass Circle.__init__(...). If you agree on the proposed modification, I can fix some of them in another PR when I find a slot.