Adding Period to ResearchSubjects in CSVClinicalTrialInformationExtractor #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdingwell
reviewed
Sep 28, 2023
src/templates/EncounterTemplate.js
Outdated
| @@ -1,11 +1,11 @@ | |||
| const { ifAllArgsObj } = require('../helpers/templateUtils'); | |||
| const { ifAllArgsObj, ifSomeArgsObj } = require('../helpers/templateUtils'); | |||
| const { coding, reference } = require('./snippets'); | |||
|
|
|||
| function periodTemplate({ startDate, endDate }) { | |||
There was a problem hiding this comment.
I think this should get moved to the templateUtils helper, it's used here and in researchsubject template. It may be applicable elsewhere as well.
rdingwell
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the period field to the
ResearchSubjectgenerated by theCSVClinicalTrialInformationExtractorin the form of new optionalstartDateandendDatefields in the CSV template. Adding either or both fields to the CSV should result in aperiodin the output.Additionally, this PR fixes
periodin theCSVEncounterExtractor. Accidentally made it so period would only show up if both start and end were present, but start and end are optional for periods, so you don't actually need both. This should work correctly now with just start or endTesting guidance
ResearchSubjectresources in the output now have properperiodfields