Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for BrowserCallable annotation #304

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

mcollovati
Copy link
Owner

Fixes #259

@quarkus-hilla-bot
Copy link
Contributor

Format Checker Report

All files are correctly formatted

@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Test Results

16 files  +1  16 suites  +1   5m 34s ⏱️ -1s
56 tests +9  56 ✔️ +9  0 💤 ±0  0 ±0 
67 runs  +9  67 ✔️ +9  0 💤 ±0  0 ±0 

Results for commit d85871f. ± Comparison against base commit 9267c19.

♻️ This comment has been updated with latest results.

@mcollovati
Copy link
Owner Author

@BrowserCallable has been introduced in Hilla 2.2.0, so this change needs #285 to be completed first

@mcollovati mcollovati marked this pull request as ready for review October 21, 2023 07:29
@mcollovati mcollovati merged commit 5d1c092 into main Oct 21, 2023
8 checks passed
@mcollovati mcollovati deleted the issues/259_browser_callable branch October 21, 2023 07:30
quarkus-hilla-bot bot pushed a commit that referenced this pull request Oct 21, 2023
mcollovati added a commit that referenced this pull request Oct 21, 2023
Fixes #259

(cherry picked from commit 5d1c092)

Co-authored-by: Marco Collovati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add tests for @BrowserCallable annotation
1 participant