Applying rubocop rules #27

vyper · 2020-10-13T23:18:19Z

Add rubocop
Remove unused ruby-styles file
Configure CI to run rubocop (depends Remove oldest and add newest ruby versions #28 because rubocop needs ruby 2.4)
Apply all rules to all files
Create issue with ruboco_todo offenses (opened Remove all offenses on .ruboco_todo.yml #29)

vyper added enhancement hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 13, 2020

vyper self-assigned this Oct 13, 2020

Remove unused file because it'll be replace by rubocop

507d5db

vyper force-pushed the applying-rubocop-rules branch from ff1cf2d to ad5d085 Compare October 15, 2020 23:25

vyper added 25 commits October 15, 2020 20:35

Add rubocop to project as development dependency

0516192

Apply rubocop Style/FrozenStringLiteralComment on all files

73a161b

Apply rubocop Style/WordArray on all files

8985411

Apply rubocop Style/PercentLiteralDelimiters on all files

996e1fa

Apply rubocop Style/SymbolArray on all files

ebbb5e9

Apply rubocop Style/StringLiterals on all files

928fb55

Apply rubocop Style/RedundantFreeze on all files

e96416d

Apply rubocop Style/EachWithObject on all files

b478ff4

Apply rubocop Style/Encoding on all files

c732038

Apply rubocop Style/ExpandPathArguments on all files

232ea5b

Apply rubocop Style/RedundantPercentQ on all files

ef49bec

Apply rubocop Style/HashSyntax on all files

32bbf22

Apply rubocop Style/Documentation on all files

8cc14b8

Apply rubocop Layout/EmptyLinesAroundModuleBody on all files

c5c6707

Apply rubocop Layout/SpaceInsideHashLiteralBraces on all files

dd0c738

Apply rubocop Layout/SpaceBeforeBlockBraces on all files

6233598

Apply rubocop Layout/SpaceAfterColon on all files

82aec20

Apply rubocop Style/NumericLiterals on all files

e1a6398

Apply rubocop Layout/DotPosition on all files

86980fd

Apply rubocop Layout/SpaceAroundEqualsInParameterDefault on all files

0445911

Apply rubocop Style/ParallelAssignment on all files

b77d344

Apply rubocop Layout/SpaceInsideBlockBraces on all files

47cb6dd

Apply rubocop Layout/SpaceAroundOperators on all files

d17c17e

Apply rubocop Layout/ElseAlignment on all files

1cd9ef3

Apply rubocop Style/SymbolProc on all files

9e83905

vyper added 21 commits October 15, 2020 20:35

Apply rubocop Style/RescueModifier on all files

d93d58e

Apply rubocop Layout/HashAlignment on all files

10dd1a9

Apply rubocop Lint/UnifiedInteger on all files

5312412

Apply rubocop Layout/EmptyLineAfterGuardClause on all files

e01951d

Apply rubocop Style/RescueStandardError on all files

ad5d5de

Apply rubocop Style/AndOr on all files

6181052

Apply rubocop Lint/InheritException on all files

3dddd5a

Apply rubocop Style/SpecialGlobalVars on all files

c31ec05

Apply rubocop Lint/UnusedBlockArgument on all files

5c32192

Apply rubocop Lint/UselessAssignment on all files

9ec53d2

Apply rubocop Style/Not on all files

108bea2

Apply rubocop Style/RaiseArgs on all files

c2e6f40

Apply rubocop Layout/IndentationWidth on all files

6e3bb3a

Apply rubocop Layout/SpaceAroundOperators on all files

6ffacb4

Apply rubocop Layout/AccessModifierIndentation on all files

71ce924

Apply rubocop Gemspec/OrderedDependencies on all files

9a2d29a

Apply rubocop Metrics/LineLength on all files

b890b32

Apply rubocop Style/CaseLikeIf on all files

936040e

Apply rubocop Lint/RaiseException on all files

d2dc8be

Apply rubocop Layout/BeginEndAlignment on all files

7a5c8ce

Apply rubocop Style/RedundantAssignment on all files

b617e50

vyper force-pushed the applying-rubocop-rules branch from fd0b030 to b617e50 Compare October 15, 2020 23:35

vyper requested review from adilsoncarvalho and marcocarvalho October 15, 2020 23:39

This was referenced Oct 15, 2020

Remove all offenses on .ruboco_todo.yml #29

Open

Add rubocop-rspec to project #30

Closed

vyper marked this pull request as ready for review October 15, 2020 23:44

adilsoncarvalho approved these changes Oct 16, 2020

View reviewed changes

vyper merged commit e04a812 into master Oct 16, 2020

vyper deleted the applying-rubocop-rules branch October 16, 2020 12:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Applying rubocop rules #27

Applying rubocop rules #27

vyper commented Oct 13, 2020 •

edited

Loading

Applying rubocop rules #27

Applying rubocop rules #27

Conversation

vyper commented Oct 13, 2020 • edited Loading

vyper commented Oct 13, 2020 •

edited

Loading