Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #222: Declares all deprecated classes to be subclasses of… #230

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

dillerm
Copy link
Collaborator

@dillerm dillerm commented Feb 13, 2024

… 'ObsoleteClass'; and creates file that preserves original class hierarchy for deprecated classes.

… 'ObsoleteClass'; and creates file that preserves original class hierarchy for deprecated classes.
@dillerm dillerm requested a review from hoganwr February 13, 2024 22:31
@dillerm
Copy link
Collaborator Author

dillerm commented Feb 13, 2024

@hoganwr is there a subdirectory in this repo that you want the deprecated class file to be moved to?

@hoganwr
Copy link
Contributor

hoganwr commented Feb 14, 2024

No I don't think so. I thought it should live at the top level along with the other "products".

@hoganwr
Copy link
Contributor

hoganwr commented Feb 29, 2024

I reviewed this pull request and it all looks good. Ok to merge and publish the new release.

Copy link
Contributor

@hoganwr hoganwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dillerm dillerm merged commit 5e4133d into main Mar 1, 2024
1 check passed
@dillerm dillerm deleted the deprecatedclasses branch March 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants