add 'human traveler role'. Fixes #191 #261
Conversation
src/templates/external_import.tsv
Outdated
There was a problem hiding this comment.
duplicate imported term from apollo
| @@ -3588,4 +3600,4 @@ AnnotationAssertion(rdfs:label obo:IAO_0000412 "imported from"@en) | |||
| AnnotationAssertion(owl:deprecated obo:OMIABIS_0000060 "true"^^xsd:boolean) | |||
| AnnotationAssertion(owl:deprecated obo:OMIABIS_0001025 "true"^^xsd:boolean) | |||
| AnnotationAssertion(owl:deprecated obo:OMIABIS_0001035 "true"^^xsd:boolean) | |||
| ) | |||
| ) | |||
There was a problem hiding this comment.
unintended deletion and re-addition of end parenthesis. appears to have occurred automatically, but needs investigated.
while the intention of this commit was only the addition of the "human traveler role" class, the addition of an obsoleted class (replacing the equivalent non-obsoleted class) and the replacement of a separate obsolete class were also completed.
There was a problem hiding this comment.
I think this was intended because the document had lines added to it, therefore requiring that the closing parenthesis be moved. Also, an obsolete class was not added; it's label was corrected to include 'obsolete'.
There was a problem hiding this comment.
The other lines involving the OP are comments. Lines beginning with '#' are comments. I think this looks good. I fixed the issue with the redundant import in external_terms.tsv.
Anything else, or all good now?
Human travel was already imported. Although the ODK import process is not impacted by the redundancy, it's not great having it here.
| @@ -500,7 +501,7 @@ SubObjectPropertyOf(obo:OMIABIS_0000008 oboInOwl:ObsoleteProperty) | |||
| AnnotationAssertion(owl:deprecated obo:OMIABIS_0000009 "true"^^xsd:boolean) | |||
| SubObjectPropertyOf(obo:OMIABIS_0000009 oboInOwl:ObsoleteProperty) | |||
|
|
|||
| # Object Property: obo:OMRSE_00000020 (is-aggregate-of) | |||
| # Object Property: obo:OMRSE_00000020 (obsolete is-aggregate-of) | |||
There was a problem hiding this comment.
This is just a change in a comment. Lines beginning with '#' are comments. The OWL API has updated the "header" comment for classes and OPs to include the labels. So as we change the labels, it will periodically rewrite these comment lines. Inconsequential change.
| @@ -823,7 +824,7 @@ AnnotationAssertion(rdfs:label obo:OMRSE_00000019 "integrated delivery network"@ | |||
| SubClassOf(obo:OMRSE_00000019 obo:OMRSE_00000015) | |||
| SubClassOf(obo:OMRSE_00000019 ObjectSomeValuesFrom(obo:RO_0000052 ObjectIntersectionOf(obo:OBI_0000245 ObjectAllValuesFrom(obo:OBI_0001688 obo:OBI_0000245)))) | |||
|
|
|||
| # Class: obo:OMRSE_00000022 (collection of organisms) | |||
| # Class: obo:OMRSE_00000022 (aggregate of objectual organisms) | |||
There was a problem hiding this comment.
This is just a change in a comment. Lines beginning with '#' are comments. The OWL API has updated the "header" comment for classes and OPs to include the labels. So as we change the labels, it will periodically rewrite these comment lines. Inconsequential change.
No description provided.