This repository has been archived by the owner on Mar 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
1.18.2 Backport | Ready to merge #112
Open
CADIndie
wants to merge
8
commits into
mcxr-org:1.19.x/QC-merge
Choose a base branch
from
CADIndie:1.19.x/QC-merge
base: 1.19.x/QC-merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You love to see it |
CADIndie
changed the title
1.18.2 Backport | Almost Ready
1.18.2 Backport | Ready to merge
Aug 13, 2022
Unable to load MC due to all three components claiming to need Fabric installed, when it is? Looks like a bad version specifier, but I'm unsure. For reference, I pulled my Core and Desktop binaries from your branch's last build, and Play from the main repo.
Loading the game without any MCXR files works without issue, putting me in MC with Fabric loaded. |
Uh, we have this as a release version, are you sure you did not forget to add the Fabric API? |
@CADIndie This was the issue; I didn't realize MultiMC was failing to get the Fabric API. My bad! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly done, few method issues left to fix and will be ready to be merged into a new branch once the main QC/MCXR merge is done.