Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpServiceError plus update Problem #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add HttpServiceError plus update Problem #3

wants to merge 1 commit into from

Conversation

mdedetrich
Copy link
Owner

This PR adds the HttpServiceError type

@mdedetrich mdedetrich force-pushed the add-http-service-error branch 6 times, most recently from d874830 to 897145f Compare May 26, 2020 08:49
@mdedetrich mdedetrich force-pushed the add-http-service-error branch 4 times, most recently from ae3adfa to a1e8fe5 Compare June 2, 2020 09:05
@mdedetrich mdedetrich force-pushed the add-http-service-error branch 6 times, most recently from 78c0175 to c5ebfb3 Compare June 11, 2020 12:30
@mdedetrich mdedetrich force-pushed the master branch 3 times, most recently from 7d65a6a to 9dd7a7e Compare July 14, 2021 16:01
@mdedetrich mdedetrich force-pushed the add-http-service-error branch 6 times, most recently from f7aac60 to 208661b Compare July 14, 2021 18:34
@coveralls
Copy link

coveralls commented Jul 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1034206002

Details

  • 0 of 46 (0.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-6.4%) to 16.575%
Changes Missing Coverage Covered Lines Changed/Added Lines %
js/src/main/scala/org/mdedetrich/webmodels/Platform.scala 0 9 0.0%
shared/src/main/scala/org/mdedetrich/webmodels/HttpServiceError.scala 0 10 0.0%
jvm/src/main/scala/org/mdedetrich/webmodels/Platform.scala 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
shared/src/main/scala/org/mdedetrich/webmodels/circe.scala 1 85.29%
Totals Coverage Status
Change from base Build 1034198359: -6.4%
Covered Lines: 30
Relevant Lines: 181
💛 - Coveralls

@mdedetrich mdedetrich force-pushed the add-http-service-error branch from 208661b to 72c09bd Compare July 15, 2021 08:39
@mdedetrich mdedetrich force-pushed the add-http-service-error branch from 72c09bd to 4d13afe Compare July 15, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @coveralls