Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Add Sec-WebSocket-* headers #25115

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 18, 2024

Adding data in for Sec-WebSocket-* headers. I am copying over info from api.WebSocket.protocol_rfc_6455 ->

"protocol_rfc_6455": {

Test results and supporting details

I began testing using BrowserStack, but support goes so far back, it's probably easier to mirror the rfc_6455 compliance entry instead.

Other changes:

  • typo fixes in parallel

Related issues and pull requests

@github-actions github-actions bot added data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Nov 18, 2024
@caugner
Copy link
Contributor

caugner commented Nov 20, 2024

@bsmth We discussed the failing check in yesterday's BCD call, and the recommendation is to file an issue in w3c/browser-specs to add this RFC.

@github-actions github-actions bot added the size:l [PR only] 101-1000 LoC changed label Nov 20, 2024
@bsmth
Copy link
Member Author

bsmth commented Nov 20, 2024

Changes to browser-specs incoming in next release:

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and copying from RFC 6455 compliance is plausible, but I would prefer to extract the unrelated fixes to a separate PR (it'll be a no-brainer to approve).

css/properties/font-variant-position.json Outdated Show resolved Hide resolved
api/SVGGraphicsElement.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Nov 22, 2024
@bsmth bsmth requested a review from caugner November 22, 2024 08:56
@caugner caugner merged commit 293d66b into mdn:main Nov 22, 2024
7 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 22, 2024
@bsmth bsmth deleted the 36590-http-headers-websockets branch November 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants