Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(workflows/node.js): suggest fixes with reviewdog (requires pull_request_target) #25154

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 20, 2024

Summary

Test results and supporting details

Related issues

@github-actions github-actions bot added infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project size:m [PR only] 25-100 LoC changed data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Nov 20, 2024
@github-actions github-actions bot removed the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 20, 2024
@caugner caugner changed the title enhance(workflows/node.js): add reviewdog steps enhance(workflows/node.js): suggest fixes with reviewdog Nov 20, 2024
@caugner caugner changed the title enhance(workflows/node.js): suggest fixes with reviewdog enhance(workflows/node.js): switch to pull_request_target + suggest fixes with reviewdog Nov 20, 2024
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 20, 2024
Comment on lines +57 to +58
"description": "`AbortController()` constructor",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[bcd-linter] reported by reviewdog 🐶

Suggested change
"description": "`AbortController()` constructor",
"description": "`AbortController()` constructor",

@github-actions github-actions bot added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Nov 20, 2024
@@ -746,7 +746,7 @@
"report-sample": {
"__compat": {
"description": "`report-sample` source value",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy#fetch_directive_syntax",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#report-sample",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[bcd-linter] reported by reviewdog 🐶

Suggested change
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#report-sample",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy#fetch_directive_syntax",

@@ -1152,7 +1152,7 @@
"strict-dynamic": {
"__compat": {
"description": "`strict-dynamic` source value",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy#fetch_directive_syntax",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#strict-dynamic",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[bcd-linter] reported by reviewdog 🐶

Suggested change
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#strict-dynamic",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy#fetch_directive_syntax",

@@ -1338,7 +1338,7 @@
"unsafe-hashes": {
"__compat": {
"description": "`unsafe-hashes` source value",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy#fetch_directive_syntax",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#unsafe-hashes",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[bcd-linter] reported by reviewdog 🐶

Suggested change
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#unsafe-hashes",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy#fetch_directive_syntax",

@caugner caugner changed the title enhance(workflows/node.js): switch to pull_request_target + suggest fixes with reviewdog enhance(workflows/node.js): suggest fixes with reviewdog (requires pull_request_target) Nov 20, 2024
@caugner caugner added the meeting agenda 🏢 Issues or pull requests in need of discussion in a project meeting. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project meeting agenda 🏢 Issues or pull requests in need of discussion in a project meeting. size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant