Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: scroll snap module #26735

Merged
merged 10 commits into from
May 15, 2023
Merged

CSS: scroll snap module #26735

merged 10 commits into from
May 15, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented May 11, 2023

Part of openwebdocs/project#147

@estelle estelle requested a review from a team as a code owner May 11, 2023 21:25
@estelle estelle requested review from dipikabh and removed request for a team May 11, 2023 21:25
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_Scroll_Snap/Basic_concepts
Title: Basic concepts of CSS Scroll Snap
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Scroll_Snap/
External URLs (5)

URL: /en-US/docs/Web/CSS/CSS_Scroll_Snap
Title: CSS Scroll Snap

(comment last updated: 2023-05-15 21:35:11)

@dipikabh dipikabh self-assigned this May 12, 2023
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @estelle for making these updates and adding "the example"!

I've added some edit suggestions.

files/en-us/web/css/css_scroll_snap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scroll_snap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scroll_snap/index.md Show resolved Hide resolved
files/en-us/web/css/css_scroll_snap/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from dipikabh May 14, 2023 00:27
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one fix needed. Otherwise this looks good. Thank you 👍

@estelle estelle merged commit 0e41c50 into mdn:main May 15, 2023
@estelle estelle deleted the scrollsnap branch May 24, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web/css/css_scroll_snap/ -
2 participants