chore(ci): Bump actions/labeler from 4 to 5 #32644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
system
yin1999
commented
Mar 11, 2024
Comment on lines
+58
to
+74
| - changed-files: | ||
| - all-globs-to-any-file: | ||
| - files/en-us/learn/** | ||
| - "!files/en-us/learn/accessibility/**" | ||
| - "!files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/**" | ||
| - "!files/en-us/learn/tools_and_testing/understanding_client-side_tools/**" | ||
| - "!files/en-us/learn/tools_and_testing/cross_browser_testing/**" | ||
| - "!files/en-us/learn/css/**" | ||
| - "!files/en-us/learn/server-side/django/**" | ||
| - "!files/en-us/learn/server-side/express_nodejs/**" | ||
| - "!files/en-us/learn/forms/**" | ||
| - "!files/en-us/learn/tools_and_testing/github/**" | ||
| - "!files/en-us/learn/html/**" | ||
| - "!files/en-us/learn/javascript/**" | ||
| - changed-files: | ||
| - any-glob-to-any-file: | ||
| - files/en-us/web/tutorials/** |
There was a problem hiding this comment.
If any of the following condition matches, the label will be added:
- one of the changed files matches
files/en-us/learn/**and also does not match any specified prefixes (accessibility,tools_and_testing/client-side_javascript_frameworks, etc.) - one of the changed files matches
files/en-us/web/tutorials/**
| with: | ||
| repo-token: "${{ secrets.GITHUB_TOKEN }}" | ||
| sync-labels: true |
There was a problem hiding this comment.
reference: mdn/translated-content#18402 (comment)
bsmth
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM, it's the same structural change as in https://github.com/mdn/translated-content/pull/18402/files, which is working as expected after landing. Thank you!
|
Is there anything blocking this :) |
I was waiting for core-dev to +1, but the changes look good (the test PRs are really helpful, ty). I think we can merge shortly! |
|
Thank you @yin1999 for the improvements 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump actions/labeler from 4 to 5.
The new input:
sync-labelis added to automatically remove unmatched labels (which is configured in label matching entries)Motivation
All the actions which is running on Node 16 will be migrated to Node 20. And the
actions/labeler@v4is running on Node 16 which may not be supported in the future.Related issues and pull requests
downstream PR: mdn/translated-content#18402
testings:
systemlabel: Test labeler: system files changes yin1999/content#9Content:Learnlabel: Test labeler: content learn yin1999/content#10Content:Firefoxlabel: Test labeler: firefox content yin1999/content#11Content:Otherlabel: Test labeler: other content yin1999/content#12