Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize with BCD v5.6.18 #36856

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Synchronize with BCD v5.6.18 #36856

merged 3 commits into from
Nov 25, 2024
+16 −8

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Nov 19, 2024 •
edited
Loading

@OnkarRuikar OnkarRuikar requested review from a team as code owners November 19, 2024 03:17
@OnkarRuikar OnkarRuikar requested review from sideshowbarker and chrisdavidmills and removed request for a team November 19, 2024 03:17
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed labels Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Preview URLs (10 pages)
Flaws (7)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/getBoxQuads does not exist
    • /en-US/docs/Web/API/Document/releaseEvents does not exist
    • /en-US/docs/Web/API/Document/queryCommandIndeterm does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/BluetoothRemoteGATTCharacteristic
Title: BluetoothRemoteGATTCharacteristic
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/BluetoothRemoteGATTCharacteristic/characteristicvaluechanged_event does not exist

(comment last updated: 2024-11-25 18:52:32)

chrisdavidmills
chrisdavidmills reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this work, @OnkarRuikar.

The content updates all look sound, but I did have a question — all the WebGPU stuff has been supported in Chromium for a while, but it is now supported in Gecko/WebKit in preview/nightly. Doesn't this still mean it counts as experimental, or no?

Chrome 113 was released in April 2023, so it hasn't been supported there for over two years (I'm looking at our definition of experimental: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Experimental_deprecated_obsolete)

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Nov 20, 2024 •
edited
Loading

all the WebGPU stuff has been supported in Chromium for a while, but it is now supported in Gecko/WebKit in preview/nightly. Doesn't this still mean it counts as experimental, or no?

@chrisdavidmills You'll have to discuss this with the BCD folks. The conversation is happening in the corresponding PR in the browser-compat-data repo: mdn/browser-compat-data#25047 (comment). It looks like you were CCed on the BCD side PR.

We'll have to hold this PR until the issue gets sorted out in BCD.

@OnkarRuikar OnkarRuikar marked this pull request as draft November 20, 2024 02:26
@sideshowbarker sideshowbarker removed their request for review November 20, 2024 06:55
@chrisdavidmills
Copy link
Contributor

From reading that BCD thread, it looks like WebGPU is not enabled in Safari, which would suggest to me that WebGPU should continue to be listed as experimental.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/l [PR only] 501-1000 LoC changed labels Nov 23, 2024
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Nov 23, 2024
@OnkarRuikar OnkarRuikar marked this pull request as ready for review November 23, 2024 15:51
@OnkarRuikar
Copy link
Contributor Author

Regarding issue pointed by Sky, the bug has been fixed in the sync bot. Remaining occurrences in content have been fixed in the previous commit.

@OnkarRuikar OnkarRuikar changed the title Synchronize with BCD v5.6.16 Synchronize with BCD v5.6.18 Nov 23, 2024
bsmth
bsmth approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all! Leaving a +1 on this 👍🏻

@bsmth bsmth merged commit 08e04f1 into mdn:main Nov 25, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the sync_bcd branch November 26, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyclouds2001 skyclouds2001 skyclouds2001 left review comments

@bsmth bsmth bsmth approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OnkarRuikar @chrisdavidmills @bsmth @skyclouds2001