Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF134: Relnote: RegExp.escape() supported #36957

Merged
merged 2 commits into from
Nov 25, 2024
Merged

FF134: Relnote: RegExp.escape() supported #36957

merged 2 commits into from
Nov 25, 2024

Conversation

hamishwillee
Copy link
Collaborator

FF134 supports RegExp.escape() in https://bugzilla.mozilla.org/show_bug.cgi?id=1918235

This adds the release note. Docs in separate PR.

Related docs work can be tracked in #36915

@hamishwillee hamishwillee requested a review from a team as a code owner November 25, 2024 02:59
@hamishwillee hamishwillee requested review from bsmth and removed request for a team November 25, 2024 02:59
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Nov 25, 2024
@hamishwillee hamishwillee mentioned this pull request Nov 25, 2024
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Preview URLs

Flaws (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/134
Title: Firefox 134 for developers
Flaw count: 1

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/RegExp/escape does not exist
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/134
Title: Firefox 134 for developers

(comment last updated: 2024-11-25 17:45:43)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Nov 25, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Nov 25, 2024
bsmth
bsmth approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hamish 👍🏻

@bsmth bsmth merged commit 6989fc7 into mdn:main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @bsmth