Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebExt: fix a typo #37327

Merged
merged 1 commit into from
Dec 21, 2024
Merged

WebExt: fix a typo #37327

merged 1 commit into from
Dec 21, 2024
+1 −1

Conversation

PassionPenguin
Copy link
Contributor

per mdn/translated-content#24900 (comment)

remove the backticks surrounding the macro

-      - : `{{WebExtAPIRef('sidebarAction.ImageDataType')}}` or `object`. This is either a single `ImageData` object or a dictionary object.
+      - : {{WebExtAPIRef('sidebarAction.ImageDataType')}} or `object`. This is either a single `ImageData` object or a dictionary object.

@PassionPenguin PassionPenguin requested a review from a team as a code owner December 21, 2024 13:16
@PassionPenguin PassionPenguin requested review from Rob--W and removed request for a team December 21, 2024 13:16
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed labels Dec 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Rob--W
Rob--W approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! WebExtAPIRef already renders <code> within <a>, so the backticks around the template are indeed redundant.

@Josh-Cena Josh-Cena merged commit 948f86c into mdn:main Dec 21, 2024
7 checks passed
@PassionPenguin PassionPenguin deleted the patch-5 branch December 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees
No one assigned
Labels
Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PassionPenguin @Rob--W @Josh-Cena