Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing EmbedLiveSample macro (issue #37366) #37652

Closed
wants to merge 1 commit into from

Conversation

sazk07
Copy link
Contributor

@sazk07 sazk07 commented Jan 14, 2025

This commit will add the EmbedLiveSample macro to the page and fix #37366

Description

Motivation

Additional details

Related issues and pull requests

This commit will add the `EmbedLiveSample` macro to the page and fix issue mdn#37366
@sazk07 sazk07 requested a review from a team as a code owner January 14, 2025 20:50
@sazk07 sazk07 requested review from hamishwillee and removed request for a team January 14, 2025 20:50
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Jan 14, 2025
Copy link
Contributor

Preview URLs

Flaws (251)

URL: /en-US/docs/Learn_web_development/Extensions/Forms/Form_validation
Title: Client-side form validation
Flaw count: 251

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Installing_basic_software
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/What_will_your_website_look_like
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Dealing_with_files
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/HTML_basics
    • and 246 more flaws omitted

@sazk07 sazk07 changed the title Fix: missing EmbedLiveSample macro (#37366) Fix: missing EmbedLiveSample macro (issue #37366) Jan 14, 2025
@Josh-Cena
Copy link
Member

Josh-Cena commented Jan 24, 2025

See #37366 for concerns about this approach. @hamishwillee any thoughts on this?

@hamishwillee
Copy link
Collaborator

The only reason to ever use the LiveSampleLink is because you can't for browser specific reasons run the code inside the page - if you could, you would never use it. So the fact it uses LiveSampleLink tells you that using the Embed version won't work. And sure enough it doesn't. Even if it did, the fix is not good because the surrounding text wasn't updated properly.

Closing this. The issue is still valid, but is possibly a yari bug.

Thanks @sazk07 for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken href in link present on page content
3 participants