Refactor notes to recommend using the flex shorthand for separate dec… #38688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:CSS
|
Preview URLs Flaws (2)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2025-03-18 03:45:29) |
estelle
reviewed
Mar 25, 2025
| @@ -10,7 +10,7 @@ browser-compat: css.properties.flex-basis | |||
| The **`flex-basis`** [CSS](/en-US/docs/Web/CSS) property sets the initial main size of a {{glossary("flex item")}}. It sets the size of the content box unless otherwise set with {{Cssxref("box-sizing")}}. | |||
|
|
|||
| > [!NOTE] | |||
| > It is recommended to use the {{cssxref("flex")}} shorthand instead of separate `flex-grow`, `flex-shrink`, and `flex-basis` declarations. We have separated them here as this document is about one of the shorthand components: the `flex-basis` property. | |||
| > It is recommended to use the {{cssxref("flex")}} shorthand instead of this longhand, as the shorthand correctly resets any unspecified components to accommodate common uses. | |||
There was a problem hiding this comment.
"correctly" seems a bit loaded to me. I prefer the original, but since I wrote it, I am biased. @dipikabh can you weigh in?
Suggested change
| > It is recommended to use the {{cssxref("flex")}} shorthand instead of this longhand, as the shorthand correctly resets any unspecified components to accommodate common uses. | |
| > It is recommended to use the {{cssxref("flex")}} shorthand instead of the component longhand properties, as the shorthand sets the unspecified components to the most common use case values. We have separated them here as this document is about one of the shorthand components: the `flex-basis` property. |
There was a problem hiding this comment.
And I trust your professional judgment more..
component longhand It's just that the term seems a little strange, and it's probably the first time it's been used in this whole document library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…larations
Description
Motivation
Additional details
Related issues and pull requests