Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contrast of required v optional form elms #38748

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Mar 21, 2025

Description

The styles are a little subtle for the demonstration.
This PR makes it more obvious what we're applying to the form based on attrs.

Fixes #26860

@bsmth bsmth requested a review from a team as a code owner March 21, 2025 11:33
@bsmth bsmth requested review from chrisdavidmills and removed request for a team March 21, 2025 11:33
@github-actions github-actions bot added Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed labels Mar 21, 2025
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Preview URLs

(comment last updated: 2025-03-24 09:38:43)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsmth bsmth merged commit eb57948 into mdn:main Mar 24, 2025
8 checks passed
@bsmth bsmth deleted the 26860-color-contrast branch March 24, 2025 09:47
@bsmth
Copy link
Member Author

bsmth commented Mar 24, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Border Color for the Optional E-mail Address Field Does Not have Enough Color Contrast
4 participants