fix: MP3 is not a container #38751
Merged
fix: MP3 is not a container #38751
+87
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove MP3 mentioned as a media container. > Another such situation is the always-popular MP3 file. An "MP3 file" is actually an MPEG-1 Audio Layer III (MP3) audio track stored within an MPEG or MPEG-2 container. This is especially interesting since while most browsers don't support using MPEG media in the <video> and <audio> elements, they may still support MP3 due to its popularity. the statement above, feels a bit redundant. I fixed the wrong info, but it feels out of place
github-actions
bot
added
Content:Learn
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2025-03-23 21:29:07) |
low-perry
changed the title
Josh-Cena
reviewed
Mar 21, 2025
files/en-us/learn_web_development/core/structuring_content/html_video_and_audio/index.md
Show resolved
Hide resolved
…delines section for better readability and correctness.
… correctness and readability.
github-actions
bot
added
Content:Media
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Hi @Josh-Cena, I believe this looks OK now. Please let me know if you have any questions or further suggestions for improvement. |
Josh-Cena
reviewed
Mar 22, 2025
Josh-Cena
changed the title
Josh-Cena
approved these changes
Mar 23, 2025
Josh-Cena
reviewed
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove MP3 mentioned as a media container.
Description
Make some technical changes regarding media containers.
Motivation
The information is wrong and misleading.
Additional details
Found this definition that clarifies why MP3 doesn'Ät belong in the media containers group.
the statement above, feels a bit redundant. I fixed the wrong info, but it feels out of place. I think the mentioning of MPEG containers should be removed completely
Related issues and pull requests
Fixes #38384 38384