Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Add missing syntax <single-animation-composition> for animation-composition #789

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 21, 2024

Description

add the missing syntax <single-animation-composition>

update status of animation-composition

Motivation

Additional details

https://drafts.csswg.org/css-animations-2/#propdef-animation-composition
https://drafts.csswg.org/css-animations-2/#typedef-single-animation-composition

Related issues and pull requests

reported in #597

/cc @lahmatiy

@skyclouds2001 skyclouds2001 changed the title Fix syntax for animation-composition fix(css): add missing syntax for animation-composition Nov 21, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 21, 2024 18:57
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 21, 2024 18:57
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team November 21, 2024 18:57
@skyclouds2001 skyclouds2001 changed the title fix(css): add missing syntax for animation-composition fix(css): Add missing syntax for animation-composition Nov 22, 2024
@skyclouds2001 skyclouds2001 changed the title fix(css): Add missing syntax for animation-composition fix(css): Add missing syntax <single-animation-composition> for animation-composition Nov 22, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM, thanks a lot 👍

@bsmth bsmth merged commit e76c914 into mdn:main Nov 22, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the animation-composition branch November 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants