Match simple-shared-worker/multiply.js to use same event-handler loop as simple-web-worker/main.js
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op logic as `simple-web-worker/main.js`
king-2929
approved these changes
Nov 21, 2024
king-2929
approved these changes
Nov 21, 2024
king-2929
approved these changes
Nov 21, 2024
king-2929
approved these changes
Nov 21, 2024
|
Thanks a lot for opening this one. Related PR landed similar fixes in: |
|
@Marcial1234 Would you like to open a pull request in mdn/content that makes this consistent there, too? |
|
Sure!
…On Thu, Dec 12, 2024, 10:39 AM Brian Smith ***@***.***> wrote:
@Marcial1234 <https://github.com/Marcial1234> Would you like to open a
pull request in mdn/content that makes this consistent there, too?
—
Reply to this email directly, view it on GitHub
<#284 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABACYZA4QR3IZGYPRZ4QVQ32FG34RAVCNFSM6AAAAABSFKE5JCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZGQ2TSMJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bsmth
reviewed
Dec 30, 2024
bsmth
reviewed
Dec 30, 2024
bsmth
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught this small inconsistency - on one SW each event handler is attached separately, in the other they're done inside a loop.
Less code seems better.
See local reference
Perhaps the external reference could be reduced/simplified as well?