Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace two HTML tags with one (with better semantics) #2842

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

dragunovartem99
Copy link
Contributor

Description

  • Simplified the HTML structure
  • Added CSS to achieve same visual effect that was created by strong + u combination

Motivation

#2838 — agreed with @estelle that we can change this example

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

@dragunovartem99 dragunovartem99 requested a review from a team as a code owner September 17, 2024 10:27
@dragunovartem99 dragunovartem99 requested review from estelle and removed request for a team September 17, 2024 10:27
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Also, congratulations on your first merged MDN interactive examples PR. Welcome to the team!

@estelle estelle merged commit 1c31eed into mdn:main Sep 17, 2024
5 checks passed
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants