Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): message anatomy diagram #36

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix(http): message anatomy diagram #36

merged 4 commits into from
Nov 26, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 19, 2024

Accept can't be a response header, so I'm fixing that.

Actually it can be:

When sent by a server in a response, Accept provides information about which content types are preferred in the content of a subsequent request to the same resource.

Regardless, some improvements to the diagram

Related issues and pull requests:

mdn/content#36029

@bsmth bsmth requested a review from a team as a code owner November 19, 2024 10:20
@bsmth bsmth requested a review from pepelsbey November 19, 2024 10:20
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Thanks. Happy to merge as is, though I wonder what’s the image optimization strategy in shared assets. For example, I noticed unusual ID attribute value in the code and it made me want to optimize this image even more:

<text id="POST / HTTP/1.1 Host: developer.mozilla.org User-Agent: curl/8.6.0 Accept: */* Content-Type: application/json Content-Length: 345 { &#34;data&#34;: &#34;ABC123&#34; }">

images/diagrams/http/messages/http-message-anatomy.svg Outdated Show resolved Hide resolved
@bsmth
Copy link
Member Author

bsmth commented Nov 26, 2024

Looks good :) Thanks. Happy to merge as is, though I wonder what’s the image optimization strategy in shared assets. For example, I noticed unusual ID attribute value in the code and it made me want to optimize this image even more:

<text id="POST / HTTP/1.1 Host: developer.mozilla.org User-Agent: curl/8.6.0 Accept: */* Content-Type: application/json Content-Length: 345 { &#34;data&#34;: &#34;ABC123&#34; }">

Good point, I didn't notice that. We should add some configs to this repo so we can compress with svgo (for example) in a consistent way

@bsmth bsmth merged commit 0432209 into main Nov 26, 2024
@bsmth bsmth deleted the http-message-anatomy branch November 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants