Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ru): remove {{jsOverrides}} macro from ru #13242

Merged
merged 2 commits into from
May 13, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented May 13, 2023

Description

remove deprecated {{jsOverrides}} macro from ru.

Motivation

The macro will render a note that shows some properties integrated from the prototype. And we never show the note
in documation (as the macro has been deprecated).

image

Related issues and pull requests

Part of: #5603

@yin1999 yin1999 requested a review from a team as a code owner May 13, 2023 11:05
@yin1999 yin1999 requested review from sashasushko and removed request for a team May 13, 2023 11:05
@github-actions github-actions bot added the l10n-ru Issues related to Russian content. label May 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2023

Preview URLs

Flaws (29)

URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/Boolean
Title: Boolean
Flaw count: 8

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/null redirects to /ru/docs/Web/JavaScript/Reference/Operators/null
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/null redirects to /ru/docs/Web/JavaScript/Reference/Operators/null
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Boolean/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Boolean/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:27
      25| }
      26| %>

27| <%- await wiki.page(url, $1, $2, $3, $4) %>
28|

/ru/docs/web/javascript/reference/global_objects/boolean references /ru/docs/web/javascript/reference/global_objects/boolean/prototype, which does not exist`

  • and 2 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/String
Title: String
Flaw count: 3

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/null redirects to /ru/docs/Web/JavaScript/Reference/Operators/null
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ru/docs/Web/API/DOMString/Binary

URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/Number
Title: Number
Flaw count: 5

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Number/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
    • /ru/docs/Web/JavaScript/Reference/Number/toInteger does not exist
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Number/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:27
      25| }
      26| %>

27| <%- await wiki.page(url, $1, $2, $3, $4) %>
28|

/ru/docs/web/javascript/reference/global_objects/number references /ru/docs/web/javascript/reference/global_objects/number/prototype, which does not exist`

  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/RegExp
Title: RegExp
Flaw count: 6

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/RegExp/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:27
      25| }
      26| %>

27| <%- await wiki.page(url, $1, $2, $3, $4) %>
28|

/ru/docs/web/javascript/reference/global_objects/regexp references /ru/docs/web/javascript/reference/global_objects/regexp/prototype, which does not exist`

  • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:27
    25| }
    26| %>

27| <%- await wiki.page(url, $1, $2, $3, $4) %>
28|

/ru/docs/web/javascript/reference/global_objects/regexp references /ru/docs/web/javascript/reference/global_objects/regexp/prototype, which does not exist`

  • broken_links:
    • Can't resolve /ru/docs/Web/JavaScript/Guide/Regular_Expressions
    • Can't resolve /ru/docs/Web/JavaScript/Guide/Regular_Expressions
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/Date
Title: Дата
Flaw count: 7

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Date/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Date/prototype does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:27
      25| }
      26| %>

27| <%- await wiki.page(url, $1, $2, $3, $4) %>
28|

/ru/docs/web/javascript/reference/global_objects/date references /ru/docs/web/javascript/reference/global_objects/date/prototype, which does not exist`

  • /ru/docs/Web/API/Window/performance redirects to /ru/docs/Web/API/performance_property
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)
External URLs (7)

URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/Boolean
Title: Boolean


URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/RegExp
Title: RegExp


URL: /ru/docs/Web/JavaScript/Reference/Global_Objects/Date
Title: Дата

(comment last updated: 2023-05-13 13:03:52)

@myshov
Copy link
Collaborator

myshov commented May 13, 2023

@yin1999 thanks! 👍

@myshov myshov merged commit 0398ed2 into mdn:main May 13, 2023
@yin1999 yin1999 deleted the remove-jsoverrides branch May 13, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ru Issues related to Russian content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants