Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] add translation to images_in_html #15295

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Conversation

rbals0445
Copy link
Contributor

Description

images_in_html에 sourceCommit을 추가하고 누락된 번역을 추가했습니다.

Motivation

Additional details

Related issues and pull requests

@rbals0445 rbals0445 requested a review from a team as a code owner August 20, 2023 07:58
@rbals0445 rbals0445 requested review from yujo11 and removed request for a team August 20, 2023 07:58
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Aug 20, 2023
@hochan222 hochan222 requested review from a team and swimjiy and removed request for yujo11 and a team September 9, 2023 17:05
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @rbals0445님, 기여해주셔서 감사합니다! 리뷰가 늦어져 죄송합니다.
다만 리뷰 전에 안내드려야 할 부분이 있어 코멘트 남깁니다.

현재 올려주신 파일이 위치한 경로(fully_untranslated_files)는 전부 번역되지 않은 파일들을 임시로 저장하는 곳으로, 전문 번역이 완료되면 올바른 위치로 이동해야 합니다.

추가로 이미지 캡션 및 코드 블럭 내 주석에 대한 설명도 번역이 필요해 보입니다.

따라서, 상기 안내에 따라 파일을 올바른 위치(ko/learn/html/multimedia_and_embedding/images_in_html/index.md)로 이동해주시고 코멘트 남겨주시면 빠르게 확인하겠습니다!

자세한 내용 및 작업 방식은 이슈의 '일부분만 번역된 페이지'를 참고해주시기 바랍니다.

@rbals0445
Copy link
Contributor Author

@swimjiy 님 안녕하세요. 리뷰 감사합니다!

  • untranslated => 원본 파일로 옮겼습니다.
  • code block 주석, 이미지 캡션에도 번역 추가 했습니다.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Preview URLs

Flaws (110)

URL: /ko/docs/Learn/HTML/Multimedia_and_embedding/Images_in_HTML
Title: HTML의 이미지
Flaw count: 110

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • and 101 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/Learn/HTML/Introduction_to_HTML/Creating_hyperlinks#url과_path에_대한_기본_지침
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
External URLs (18)

URL: /ko/docs/Learn/HTML/Multimedia_and_embedding/Images_in_HTML
Title: HTML의 이미지

(comment last updated: 2023-09-12 09:16:40)

Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @rbals0445님, 기여해주셔서 감사합니다😊

리뷰 코멘트 남겨놓았으니 편하게 확인 부탁드리고, 필요 시 멘션 주시면 빠르게 확인하겠습니다.

@rbals0445
Copy link
Contributor Author

rbals0445 commented Sep 12, 2023

@swimjiy 님, 꼼꼼한 리뷰 정말 감사합니다. 실수가 굉장히 많았네요. 아래 내용 반영했습니다~! 969becd

  • 상대 URL, 절대 URL로 통일
  • hash에 한글 번역본이 있는경우 알맞게 설정
  • 원문이 들어간 부분 제거
  • 오번역 수정

Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 꽤 많았는데 꼼꼼히 반영해주셔서 감사합니다! 잘 반영된 것 같아 머지하도록 하겠습니다. 고생하셨습니다~

@swimjiy swimjiy merged commit 6ba6953 into mdn:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants