Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko]: add index.md in web/glossary/base64 #15609

Merged
merged 3 commits into from
Sep 17, 2023
Merged

[ko]: add index.md in web/glossary/base64 #15609

merged 3 commits into from
Sep 17, 2023

Conversation

IMHOJEONG
Copy link
Contributor

Description

#15211 의 진행상황 중, web/glossary/base64 부분입니다.

Motivation

web/glossary 접근했는데, 한국어 파일은 없어서 시작하게 되었습니다.

Additional details

Related issues and pull requests

#14965
#15211

@IMHOJEONG IMHOJEONG requested a review from a team as a code owner September 3, 2023 11:16
@IMHOJEONG IMHOJEONG requested review from pje1740 and removed request for a team September 3, 2023 11:16
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Sep 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023 •
edited
Loading

Preview URLs

External URLs (3)

URL: /ko/docs/Glossary/Base64
Title: Base64

(comment last updated: 2023-09-14 00:11:35)

@IMHOJEONG IMHOJEONG mentioned this pull request Sep 3, 2023
Closed
pje1740
pje1740 requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@pje1740 pje1740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 코멘트 확인 부탁드릴게요!

files/ko/glossary/base64/index.md Outdated Show resolved Hide resolved
files/ko/glossary/base64/index.md Outdated Show resolved Hide resolved
files/ko/glossary/base64/index.md Outdated Show resolved Hide resolved
files/ko/glossary/base64/index.md Outdated Show resolved Hide resolved
files/ko/glossary/base64/index.md Outdated Show resolved Hide resolved
hochan222
hochan222 requested changes Sep 9, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰어님께서 리뷰주신 사항들 반영이 되지 않았는데, resolved 처리된 리뷰들이 있는듯하여 확인 한번 부탁드려요~!

@IMHOJEONG
Copy link
Contributor Author

IMHOJEONG commented Sep 11, 2023 •
edited
Loading

@pje1740 님, @hochan222 님 안녕하세요.
제 로컬에만 반영해놓고 올려두지 않았네요 ㅠㅠ
피드백 주셨는데, 늦게 확인해서 죄송합니다. 바로 수정해서 푸시해두겠습니다.

pje1740
pje1740 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@pje1740 pje1740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
@hochan222 같이 고민해주셔서 감사합니다!

hochan222
hochan222 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pje1740 님 리뷰 머지하지 않으신 이유가 혹시 아래 사진의 이유라면 다음에는 Dismiss review로 제거 후 병합해주셔도 좋을듯합니다.

image

모두 고생 많으셨습니다! 병합하겠습니다! 좋은 하루 보내세요 :)

@hochan222 hochan222 merged commit f0d41e8 into mdn:main Sep 17, 2023
@IMHOJEONG IMHOJEONG deleted the web/glossary/base64 branch September 17, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pje1740 pje1740 pje1740 approved these changes

@hochan222 hochan222 hochan222 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IMHOJEONG @hochan222 @pje1740