Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn]: add View Transitions API document translation #15643

Merged
merged 28 commits into from
Sep 18, 2023
Merged

[zh-cn]: add View Transitions API document translation #15643

merged 28 commits into from
Sep 18, 2023

Conversation

suiyun39
Copy link
Contributor

@suiyun39 suiyun39 commented Sep 5, 2023

Description

Add View Transitions API document translation of zh-cn

Motivation

Additional details

Related issues and pull requests

@suiyun39 suiyun39 requested a review from a team as a code owner September 5, 2023 09:27
@suiyun39 suiyun39 requested review from yin1999 and removed request for a team September 5, 2023 09:27
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Preview URLs (12 pages)
Flaws (1)

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/API/ViewTransition/finished
Title: ViewTransition:finished 属性
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback
External URLs (19)

URL: /zh-CN/docs/Web/API/View_Transitions_API
Title: View Transitions API


URL: /zh-CN/docs/Web/API/ViewTransition
Title: ViewTransition


URL: /zh-CN/docs/Web/API/ViewTransition/finished
Title: ViewTransition:finished 属性


URL: /zh-CN/docs/Web/API/ViewTransition/skipTransition
Title: ViewTransition:skipTransition() 方法


URL: /zh-CN/docs/Web/API/ViewTransition/updateCallbackDone
Title: ViewTransition:updateCallbackDone 属性


URL: /zh-CN/docs/Web/API/ViewTransition/ready
Title: ViewTransition:ready 属性


URL: /zh-CN/docs/Web/API/Document/startViewTransition
Title: Document:startViewTransition() 方法


URL: /zh-CN/docs/Web/CSS/::view-transition-image-pair
Title: ::view-transition-image-pair


URL: /zh-CN/docs/Web/CSS/::view-transition-new
Title: ::view-transition-new


URL: /zh-CN/docs/Web/CSS/::view-transition-old
Title: ::view-transition-old


URL: /zh-CN/docs/Web/CSS/::view-transition
Title: ::view-transition


URL: /zh-CN/docs/Web/CSS/::view-transition-group
Title: ::view-transition-group

(comment last updated: 2023-09-16 15:46:32)

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @suiyun39, I've listed some common issue in this PR. Please check all the files and apply a full correction.

files/zh-cn/web/api/document/startviewtransition/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/document/startviewtransition/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/document/startviewtransition/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/document/startviewtransition/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/document/startviewtransition/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions for the first two documents

files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/view_transitions_api/index.md Outdated Show resolved Hide resolved
@yin1999
Copy link
Member

yin1999 commented Sep 7, 2023

GitHub has provide UI to apply all the suggestions in one commit, which would be better for the reviewer to check feedbacks: https://docs.github.com/zh/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

You could try this feature in files for the coming suggestions.

@suiyun39
Copy link
Contributor Author

suiyun39 commented Sep 7, 2023

GitHub has provide UI to apply all the suggestions in one commit, which would be better for the reviewer to check feedbacks: https://docs.github.com/zh/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

You could try this feature in files for the coming suggestions.

This feature is really great, thanks for the reminder.

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next three documents

files/zh-cn/web/api/viewtransition/finished/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/finished/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/finished/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/index.md Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/ready/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/ready/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/viewtransition/ready/index.md Outdated Show resolved Hide resolved
@suiyun39 suiyun39 requested a review from yin1999 September 9, 2023 15:52
@suiyun39 suiyun39 requested a review from yin1999 September 16, 2023 15:46
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suiyun39 💯

@yin1999 yin1999 changed the title [zh-cn] Add View Transitions API document translation [zh-cn]: add View Transitions API document translation Sep 18, 2023
@yin1999 yin1999 merged commit ee1bbb5 into mdn:main Sep 18, 2023
@suiyun39
Copy link
Contributor Author

Thanks also for your review and suggestions.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants