Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14447 #15884

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix #14447 #15884

merged 2 commits into from
Sep 26, 2023

Conversation

SphinxKnight
Copy link
Member

An update to fix #14447 + an addition of a new embedded example.

@SphinxKnight SphinxKnight requested a review from a team as a code owner September 16, 2023 16:08
@SphinxKnight SphinxKnight requested review from cw118 and removed request for a team September 16, 2023 16:08
@SphinxKnight SphinxKnight added the l10n-fr Issues related to French content. label Sep 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023

Preview URLs

Flaws (2)

URL: /fr/docs/Web/CSS/grid-column-start
Title: grid-column-start
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (5 in common of 8 possible)
External URLs (1)

URL: /fr/docs/Web/CSS/grid-column-start
Title: grid-column-start

(comment last updated: 2023-09-25 10:30:00)

Copy link
Member

@tristantheb tristantheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for the content 👌🏻

{{EmbedLiveSample('Exemples', '230', '420')}}
#### Résultat

{{EmbedLiveSample('Définir la colonne de début pour un élément de grille', '230', '420')}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SphinxKnight Par pur suivi des méthodes US, est-ce qu'il ne serait pas mieux de mettre les underscores à la place des espaces sur la valeur 1 (c'est vraiment par pure convention personnelle sur les nommages que j'ai cette question, si tu n'en vois pas l'utilité je serai pas contre ton point de vue ^^)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour expliciter la démarche : j'ai enlevé l'argument et ça ne fonctionnait pas (sans doute un cas de mdn/yari#5005 ), j'ai eu un souvenir fugace qu'une "amélioration" avait été apportée pour pouvoir utiliser le titre tel quel (plutôt que slugifié) et donc voilà.

Bref, j'ai eu la flemme et tu as raison :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de soucis xD


#### Résultat

{{EmbedLiveSample('Placement relatif aux lignes', '230', '220')}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voir question relative plus haut.

@tristantheb tristantheb self-assigned this Sep 20, 2023
@tristantheb tristantheb removed the request for review from cw118 September 20, 2023 11:36
@tristantheb tristantheb merged commit 2057ca9 into mdn:main Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Y a-t-il des restrictions/contraintes à l'utilisation de span ?
2 participants