Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-cn: init translation of cycletracker manifest #15890

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

hanyujie2002
Copy link
Contributor

Description

Same as title

Motivation

ditto

Additional details

None

Related issues and pull requests

Related to #15548

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner September 17, 2023 13:09
@hanyujie2002 hanyujie2002 requested review from jasonren0403 and removed request for a team September 17, 2023 13:09
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Sep 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023

Preview URLs

Flaws (14)

URL: /zh-CN/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/Manifest_file
Title: 经期跟踪器:清单和图标
Flaw count: 14

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 9 more flaws omitted
External URLs (3)

URL: /zh-CN/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/Manifest_file
Title: 经期跟踪器:清单和图标

(comment last updated: 2023-09-19 06:40:18)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yin1999
Copy link
Member

yin1999 commented Sep 17, 2023

One suggestion, could you setup node runtime locally and install pre-commit hook for this repo (run yarn install so the pre-commit hook would be installed)?

@hanyujie2002
Copy link
Contributor Author

hanyujie2002 commented Sep 17, 2023

One suggestion, could you setup node runtime locally and install pre-commit hook for this repo (run yarn install so the pre-commit hook would be installed)?

I am sorry, It told me to install visual studio but I don't want to install it😢

image

Thank you for your suggestion and I will consider it sincerely 😁

@yin1999
Copy link
Member

yin1999 commented Sep 17, 2023

One suggestion, could you setup node runtime locally and install pre-commit hook for this repo (run yarn install so the pre-commit hook would be installed)?

I am sorry, It told me to install visual studio but I don't want to install it😢

image Thank you for your suggestion and I will consider it sincerely 😁

You could try to install VS build tools

@hanyujie2002
Copy link
Contributor Author

One suggestion, could you setup node runtime locally and install pre-commit hook for this repo (run yarn install so the pre-commit hook would be installed)?

I am sorry, It told me to install visual studio but I don't want to install it😢
image
Thank you for your suggestion and I will consider it sincerely 😁

You could try to install VS build tools

Thank you, I will have a try

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanyujie2002 👍. I've pushed a commit to align the translation of title

@yin1999 yin1999 merged commit 20bae1b into mdn:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants