Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko]:add index.md for web/glossary/favicon #15962

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[ko]:add index.md for web/glossary/favicon #15962

merged 1 commit into from
Oct 9, 2023

Conversation

IMHOJEONG
Copy link
Contributor

Description

#15231 의 진행상황 중, web/glossary/favicon 부분의 일부분 파일들입니다.

Related issues and pull requests

#14965
#15231

@IMHOJEONG IMHOJEONG requested a review from a team as a code owner September 20, 2023 03:12
@IMHOJEONG IMHOJEONG requested review from swimjiy and removed request for a team September 20, 2023 03:12
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Sep 20, 2023
@IMHOJEONG IMHOJEONG mentioned this pull request Sep 20, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023 •
edited
Loading

Preview URLs

External URLs (3)

URL: /ko/docs/Glossary/Favicon
Title: 파비콘 (Favicon)

(comment last updated: 2023-10-04 02:13:30)

swimjiy
swimjiy reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여해주셔서 감사합니다 @IMHOJEONG님, 간단한 코멘트 남겨 드렸으니 편하게 확인 부탁드립니다~

files/ko/glossary/favicon/index.md Outdated Show resolved Hide resolved
@IMHOJEONG IMHOJEONG force-pushed the web/glossary/favicon branch from 9a3a026 to 2c805c5 Compare October 4, 2023 02:10
swimjiy
swimjiy approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 반영해주셔서 머지하도록 하겠습니다. 고생하셨습니다!

@swimjiy swimjiy merged commit 2cff098 into mdn:main Oct 9, 2023
7 checks passed
@IMHOJEONG IMHOJEONG deleted the web/glossary/favicon branch October 9, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swimjiy swimjiy swimjiy approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IMHOJEONG @swimjiy