Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): add url locale checker #16154

Merged
merged 6 commits into from
Oct 10, 2023
Merged

feat(ci): add url locale checker #16154

merged 6 commits into from
Oct 10, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Sep 27, 2023

Description

add url locale checker

Related issues and pull requests

#7413

@github-actions github-actions bot added the system Infrastructure and configuration for the project label Sep 27, 2023
@github-actions github-actions bot added l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. labels Oct 8, 2023
@yin1999 yin1999 marked this pull request as ready for review October 8, 2023 10:28
@yin1999 yin1999 requested review from a team as code owners October 8, 2023 10:28
@yin1999 yin1999 requested review from sashasushko and wisedog and removed request for a team October 8, 2023 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023 •
edited
Loading

Preview URLs (7 pages)
Flaws (112)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ru/docs/Learn/CSS/CSS_layout
Title: CSS layout
Flaw count: 86

  • macros:
    • /ru/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /ru/docs/Learn/CSS/Building_blocks/Organizing does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Organizing
    • /ru/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper
    • /ru/docs/Learn/CSS/Building_blocks/A_cool_looking_box does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/A_cool_looking_box
    • /ru/docs/Learn/CSS/CSS_layout/Media_queries does not exist but fell back to /en-US/docs/Learn/CSS/CSS_layout/Media_queries
    • and 77 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Glossary/Accessible_name
Title: 접근 가능한 이름 (Accessible name)
Flaw count: 11

  • macros:
    • /ko/docs/Web/HTML/Element/td does not exist but fell back to /en-US/docs/Web/HTML/Element/td
    • /ko/docs/Web/HTML/Element/table does not exist but fell back to /en-US/docs/Web/HTML/Element/table
    • /ko/docs/Web/HTML/Element/textarea does not exist but fell back to /en-US/docs/Web/HTML/Element/textarea
    • /ko/docs/Web/HTML/Element/input does not exist but fell back to /en-US/docs/Web/HTML/Element/input
    • /ko/docs/Web/HTML/Element/div does not exist but fell back to /en-US/docs/Web/HTML/Element/div
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 1 more flaws omitted

URL: /ko/docs/Glossary/Effective_connection_type
Title: 유효 연결 타입 (Effective connection type)
Flaw count: 3

  • macros:
    • /ko/docs/Web/API/NetworkInformation does not exist but fell back to /en-US/docs/Web/API/NetworkInformation
    • /ko/docs/Web/API/NetworkInformation/effectiveType does not exist but fell back to /en-US/docs/Web/API/NetworkInformation/effectiveType
  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Glossary/Shadow_tree
Title: 쉐도우 트리 (Shadow tree)
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/Element/shadowRoot does not exist but fell back to /en-US/docs/Web/API/Element/shadowRoot
    • /ko/docs/Web/API/Element/attachShadow does not exist but fell back to /en-US/docs/Web/API/Element/attachShadow
    • /ko/docs/Web/API/ShadowRoot does not exist but fell back to /en-US/docs/Web/API/ShadowRoot
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Glossary/Page_load_time
Title: 페이지 로드 시간 (Page load time)
Flaw count: 6

  • macros:
    • /ko/docs/Web/API/PerformanceNavigationTiming does not exist but fell back to /en-US/docs/Web/API/PerformanceNavigationTiming
    • /ko/docs/Web/API/PerformanceResourceTiming does not exist but fell back to /en-US/docs/Web/API/PerformanceResourceTiming
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf
Title: Array.prototype.indexOf()
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback
External URLs (1)

URL: /ko/docs/Glossary/Enumerated
Title: 열거형 (Enumerated)

(comment last updated: 2023-10-10 09:25:46)

sashasushko
sashasushko reviewed Oct 9, 2023
View reviewed changes
files/ru/learn/css/css_layout/index.md
@@ -41,7 +41,7 @@ slug: Learn/CSS/CSS_layout
- : **CSS Media Query** позволяют писать CSS под разные условия, например "область просмотра шире 480 пикселей". Медиавыражения являются ключевой частью отзывчивого веб-дизайна, поскольку они позволяют создавать различные макеты в зависимости от размера области просмотра. Они также могут использоваться для определения других особенностей среды, в которой работает ваш сайт, например, использует ли пользователь сенсорный экран, а не мышь. В этом руководстве вы сперва познакомитесь с синтаксисом медиавыражений, а после разберёте их использование на интерактивном примере, показывающем, как простой дизайн можно сделать отзывчивым.
- [Устаревшие методы вёрстки](/ru/docs/Learn/CSS/CSS_layout/Legacy_Layout_Methods)
- : Grid-системы - это очень распространённая возможность, используемая в CSS layouts, и до CSS Grid Layout они, как правило, реализовывались с помощью floats или других возможностей вёрстки. Вы представляете свою вёрстку в виде заданного числа столбцов (например, 4 или 6), а затем вы помещаете содержимое в эти воображаемые столбцы. В этом разделе мы рассмотрим, как работают эти старые методы, чтобы вы понимали, как они использовались, если столкнётесь со старыми проектами.
- [Поддержка старыми браузерами](/en-US/docs/Learn/CSS/CSS_layout/Supporting_Older_Browsers)
- [Поддержка старыми браузерами](/ru/docs/Learn/CSS/CSS_layout/Supporting_Older_Browsers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yin1999 thanks for helping. Could you help me to understand the new rules? Now we should place link only for our "own locales"? In that case, it's ok that the page https://developer.mozilla.org/ru/docs/Learn/CSS/CSS_layout/Supporting_Older_Browsers isn't existing?

Copy link
Member Author

@yin1999 yin1999 Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,it's ok. yari would automatically falls back to en-US.

image

And doing so can reduce our workload of maintaining documents in the future, without having to update links to other documents after localizing non-existing pages.

For the flaws showing in the preview pages, we have a discuession on it: https://github.com/orgs/mdn/discussions/144.

wisedog
wisedog approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : >

@yin1999
Copy link
Member Author

yin1999 commented Oct 10, 2023

As there is only one url fixed for ru. And the fix looks fine, I'm going to merge this PR.

Thanks for all the reviews :)

@yin1999 yin1999 merged commit 63a19d1 into mdn:main Oct 10, 2023
9 of 11 checks passed
@yin1999 yin1999 deleted the add-locale-check branch October 10, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashasushko sashasushko sashasushko left review comments

@wisedog wisedog wisedog approved these changes

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content. l10n-ru Issues related to Russian content. system Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yin1999 @caugner @wisedog @sashasushko