Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fr] Updating HTML <dialog> element - fix #16297 #16334

Merged
merged 6 commits into from
Oct 5, 2023
Merged

[fr] Updating HTML <dialog> element - fix #16297 #16334

merged 6 commits into from
Oct 5, 2023

Conversation

tristantheb
Copy link
Member

Description

  • Fixing examples
  • Updating intriduction from en-US
  • Updating example title from en-US
  • Adding missing example
  • Adding more "see also" links

This is part one of update

  • Adding more example explain
  • Adding "Accessibility considerations" section

This is part two of update

Motivation

Providing refreshed content and fixed example.

Related issues and pull requests

Fix #16297

@tristantheb
UPDT: Refreshing introduction and examples
f497e9d 
* Fixing examples
* Updating intriduction from en-US
* Updating example title from en-US
* Adding missing example
* Adding more "see also" links

> This is part one of update
@tristantheb tristantheb added the l10n-fr Issues related to French content. label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

Preview URLs

Flaws (18)

URL: /fr/docs/Web/HTML/Element/dialog
Title: <dialog> : l'élément de boîte de dialogue
Flaw count: 18

  • macros:
    • /fr/docs/Web/HTML/Attributes/dirname does not exist but fell back to /en-US/docs/Web/HTML/Attributes/dirname
    • /fr/docs/Web/HTML/Attributes/placeholder does not exist but fell back to /en-US/docs/Web/HTML/Attributes/placeholder
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 10 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 9 possible)

(comment last updated: 2023-10-05 07:24:59)

github-actions[bot]
github-actions bot reviewed Oct 3, 2023
View reviewed changes
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
@tristantheb
UPDT: Adding content
3b30cce 
* Explaining third example
* Adding accessibility concern
* FIX: Missing tab on note
github-actions[bot]
github-actions bot reviewed Oct 3, 2023
View reviewed changes
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
files/fr/web/html/element/dialog/index.md Outdated Show resolved Hide resolved
@tristantheb tristantheb marked this pull request as ready for review October 3, 2023 14:29
@tristantheb tristantheb requested a review from a team as a code owner October 3, 2023 14:29
@tristantheb tristantheb requested review from cw118 and removed request for a team October 3, 2023 14:29
SphinxKnight
SphinxKnight approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @tristantheb 😎 - je me suis permis un commit

@SphinxKnight SphinxKnight merged commit d874949 into mdn:main Oct 5, 2023
7 checks passed
@tristantheb tristantheb deleted the fix/html-element-dialog branch October 24, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@SphinxKnight SphinxKnight SphinxKnight approved these changes

@cw118 cw118 Awaiting requested review from cw118 cw118 is a code owner automatically assigned from mdn/yari-content-fr

Assignees
No one assigned
Labels
l10n-fr Issues related to French content.
Projects
l10n-fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken exemple on "Dialog" in French version
2 participants
@tristantheb @SphinxKnight